Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated exported id #21

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fix duplicated exported id #21

merged 1 commit into from
Jun 9, 2021

Conversation

j3rem1e
Copy link
Contributor

@j3rem1e j3rem1e commented Apr 6, 2021

Closes #10

  1. A list of allocated identifiers is build from the component
  2. If a generated id is in this list, then a warning is emitted, and an hash is added to the id. The id stays stable between build, but the user is encouraged to configure his own id

@shilman shilman added the bug Something isn't working label Jun 9, 2021
shilman
shilman approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 984e9d6 into storybookjs:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Story name can conflict with imports
2 participants
@j3rem1e @shilman